-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the resample_dt_ member of TOTG back to const #1776
Conversation
Codecov ReportBase: 0.00% // Head: 50.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
=========================================
+ Coverage 0 50.27% +50.27%
=========================================
Files 0 374 +374
Lines 0 31277 +31277
=========================================
+ Hits 0 15722 +15722
- Misses 0 15555 +15555
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this so quickly. Only request would be to change the free function name to include TOTG somewhere, since trajectory_processing::computeTimeStamps()
doesn't reveal that.
moveit_core/trajectory_processing/test/test_time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
4582e6a
to
e79f7a3
Compare
e79f7a3
to
19ad6a8
Compare
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
19ad6a8
to
2283ca4
Compare
Based on the comment here: #1771 (comment)
Shuffle a function around so that the
resample_dt_
member of TOTG can be const again.