Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version of TOTG computeTimeStamps() for a fixed num waypoints #1771

Merged
merged 9 commits into from
Dec 1, 2022

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Dec 1, 2022

Fixes #1769

@AndyZe AndyZe requested a review from sjahr December 1, 2022 00:49
@AndyZe AndyZe force-pushed the andyz/totg_fixed_num_waypoints branch from 15abc2a to e4e8d4d Compare December 1, 2022 01:25
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 50.92% // Head: 50.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f4cce24) compared to base (50b03a1).
Patch coverage: 77.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
+ Coverage   50.92%   50.93%   +0.01%     
==========================================
  Files         378      378              
  Lines       31671    31680       +9     
==========================================
+ Hits        16126    16132       +6     
- Misses      15545    15548       +3     
Impacted Files Coverage Δ
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...cessing/src/time_optimal_trajectory_generation.cpp 88.26% <77.78%> (-0.16%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.83% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a useful feature of people know what they're doing

@AndyZe AndyZe force-pushed the andyz/totg_fixed_num_waypoints branch from 6c09d46 to f382ffe Compare December 1, 2022 14:31
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation is good now. If you don't like the small clarification of your comment I suggested, feel free to reject it

Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
@AndyZe AndyZe merged commit bf0496f into moveit:main Dec 1, 2022
@AndyZe AndyZe deleted the andyz/totg_fixed_num_waypoints branch December 1, 2022 20:30
private:
bool doTimeParameterizationCalculations(robot_trajectory::RobotTrajectory& trajectory,
const Eigen::VectorXd& max_velocity,
const Eigen::VectorXd& max_acceleration) const;

const double path_tolerance_;
const double resample_dt_;
double resample_dt_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyZe it's actually error-prone that resample_dt_ is being changed implicitly by the new computeTimeStamps() function. The other member functions have been const for a reason, namely to allow repeatable results. Now the results of the old computeTimeStamps() depends on if the new function has been called and whatever num_waypoints has been used. Please fix that, either by implementing a free function that creates two instances of TOTG (one for each resample_dt), or by providing a private computeTimeStampsInternal function that accepts resample_dt as argument so that you can call that one twice without changing the member variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll fix this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a capability to specify the exact num_waypoints of a trajectory
3 participants