Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small terminal output adjustments #1818

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Dec 20, 2022

Description

  • Change output level of some prints in CHOMP from INFO to DEBUG to avoid a wall of text at runtime
  • Remove newline in kdl_kinematics from
[moveit_run_benchmark-1] [INFO] [1671539632.233486591] [moveit_kinematics_base.kinematics_base]: Joint weights for group 'panda_arm':
[moveit_run_benchmark-1] 1 1 1 1 1 1 1

to

[moveit_run_benchmark-1] [INFO] [1671540088.585070396] [moveit_kinematics_base.kinematics_base]: Joint weights for group 'panda_arm': 1 1 1 1 1 1 1

I was confused of the old version because this is the only place in MoveIt2 where a new line is added to print the values and I failed to connect 1 1 1 1 1 1 1 to the line above.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr force-pushed the pr-small_output_improvements branch from 1f6c3c3 to bbded20 Compare December 20, 2022 14:03
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 50.32% // Head: 50.33% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1493a25) compared to base (2e610aa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
+ Coverage   50.32%   50.33%   +0.01%     
==========================================
  Files         374      374              
  Lines       31325    31325              
==========================================
+ Hits        15762    15764       +2     
+ Misses      15563    15561       -2     
Impacted Files Coverage Δ
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.79% <ø> (-1.13%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.95% <0.00%> (+0.08%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.69% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr force-pushed the pr-small_output_improvements branch from bbded20 to 05a862a Compare December 20, 2022 16:01
@sjahr sjahr force-pushed the pr-small_output_improvements branch from 05a862a to 1493a25 Compare December 20, 2022 21:11
@sjahr sjahr merged commit 43b06e9 into moveit:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants