Fix wrong use of C msg headers

[rhaschke]

You inconsistently use C++ and C msg headers! This PR fixes all occurrences of wrong C header usage.

I'm really wondering why you didn't run into issues due to this before. When including moveit/utils/moveit_error_code.h, I'm getting these errors:

/opt/ros/rolling/include/moveit/utils/moveit_error_code.h:48:1: error: expected class-name before ‘{’ token
   48 | {
      | ^
/opt/ros/rolling/include/moveit/utils/moveit_error_code.h:54:43: error: ‘MoveItErrorCodes’ in namespace ‘moveit_msgs::msg’ does not name a type
   54 |   MoveItErrorCode(const moveit_msgs::msg::MoveItErrorCodes& code)

That's not surprising as the C++ and C types are fundamentally different, e.g.
moveit_msgs::msg::MoveItErrorCodes vs. moveit_msgs__msg__MoveItErrorCodes.

I guess you include the corresponding .hpp header somewhere else then...

[codecov]

Codecov Report

Base: 50.43% // Head: 50.42% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (ad302b9) compared to base (8d1dace).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   50.43%   50.42%   -0.01%     
==========================================
  Files         374      374              
  Lines       31335    31335              
==========================================
- Hits        15802    15797       -5     
- Misses      15533    15538       +5     

Impacted Files	Coverage Δ
.../distance_field/src/propagation_distance_field.cpp	93.84% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp	65.97% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp	45.26% <0.00%> (-0.43%)	⬇️
...e/collision_detection_fcl/src/collision_common.cpp	73.76% <0.00%> (-0.22%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AndyZe]

I found quite a few more, for example:

moveit_core/planning_scene/src/planning_scene.cpp:#include <octomap_msgs/conversions.h>

Found with:

grep -r ".h>" | grep "_msg"

[rhaschke]

You need to use this regex: /msgs/.*\.h(?!p) which I did.
The file you mention, @AndyZe, is not a generated message header.

[AndyZe]

You mean that messages from debians should be included differently than messages built along with MoveIt packages? Hmm, that's annoying. I'll defer to somebody else to review the PR, then.

[rhaschke]

I mean that only header files auto-generated via rosidl should be handled as suggested. The one you pointed out is a manually provided file: octomap_msgs/conversions.h

[henningkayser]

Thank you!