-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from qos_event.hpp to event_handler.hpp #2111
Conversation
Waiting until |
Resolves #2113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will break main on Humble, we need to check for the distro and include the header accordingly
moveit_ros/moveit_servo/src/teleop_demo/joystick_servo_example.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/planning_components_tools/src/visualize_robot_collision_volume.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/planning_scene_monitor/demos/demo_scene.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/planning_scene_monitor/src/current_state_monitor_middleware_handle.cpp
Outdated
Show resolved
Hide resolved
@JafarAbdi we have a dedicated Humble branch now, though. I think it would be OK to break main on Humble. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
=========================================
+ Coverage 0 50.84% +50.84%
=========================================
Files 0 391 +391
Lines 0 32167 +32167
=========================================
+ Hits 0 16351 +16351
- Misses 0 15816 +15816
... and 390 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
That branch is stable and used for binary releases. Rolling is very unstable (at least that was my experience) to be used by a general user. IMHO, we should always aim to have support for rolling + latest LTS version on main (for people who are ok with building from source to get the latest features) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution feels like overkill in comparison to disabling -W#warning
but it's a valid solution nonetheless. Do we plan on removing this extra infrastructure as soon as it's no longer needed? Do we know how soon Humble will get access to this header it needs?
@@ -1,10 +1,10 @@ | |||
add_executable(cancel_action cancel_action.cpp) | |||
ament_target_dependencies(cancel_action ${THIS_PACKAGE_INCLUDE_DEPENDS}) | |||
target_link_libraries(cancel_action ${LIBRARIES}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this previously dereferencing a variable that didn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable exists but it should not be necessary to link against the target list in this variable
Co-authored-by: Chris Thrasher <chrisjthrasher@gmail.com>
@@ -41,6 +41,20 @@ macro(moveit_package) | |||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | |||
set(CMAKE_CXX_EXTENSIONS OFF) | |||
|
|||
if(NOT DEFINED ENV{ROS_DISTRO}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: this breaks the moveit2_packages: https://github.com/moveit/moveit2_packages/actions/runs/4749763095/jobs/8437320692
The better way would be to check the rclcpp version where this change was introduced.
Description
Address error happening here #2020 (review)
Checklist