-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Servo] Fix bugs when halting for collision + transforming commands to planning frame #2350
Conversation
Moved some of the unrelated fixes from #2349 (which I'm not sure will actually help) to here. These changes should definitely go in. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
==========================================
- Coverage 50.76% 50.72% -0.03%
==========================================
Files 386 386
Lines 31963 31970 +7
==========================================
- Hits 16223 16214 -9
- Misses 15740 15756 +16
☔ View full report in Codecov by Sentry. |
Great catch! robot_state->copyJointGroupPositions(joint_model_group, target_state.positions); here, no need to check for the collision flag in |
@ibrahiminfinite Implemented your comments, and also found a follow-on bug with converting twists to planning frame, so I changed this PR name/description. |
0953243
to
d8e5b32
Compare
20f3666
to
156125e
Compare
104e333
to
f46c3bc
Compare
Tested this, all the demos worked fine and applying twist commands to panda also worked as expected. |
…o planning frame (moveit#2350)
This PR fixes a few bugs:
lookupTransform()
call had arguments reversed, causing drift. Fixes the issue described in [Servo] Using TF lookup instead of robot state for transforms causing drift #2352, and applies the same fixes to pose tracking conversions as well.smoothHalt()
function to use a nonzero threshold instead of exact floating-point comparison to zero.tf2::TransformBuffer
andtf2::TransformListener
that were already implicit in the Planning Scene Monitor.Additionally, it simplifies some of the new twist conversion code from #2311 so there is no need to reorder a vector.
Closes #2352