Fix Servo singularity scaling unit tests #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
==========================================
- Coverage 50.46% 50.36% -0.09%
==========================================
Files 385 385
Lines 31772 31767 -5
==========================================
- Hits 16029 15996 -33
- Misses 15743 15771 +28
☔ View full report in Codecov by Sentry. |
…m/ros-planning/moveit2 into update-link-tforms-in-servo-tests
8 tasks
sea-bass
force-pushed
the
update-link-tforms-in-servo-tests
branch
from
f3d5dcf
to
bc110b3
Compare
sjahr
approved these changes
Oct 9, 2023
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this pull request
Dec 4, 2023
* Fix Servo singularity scaling unit tests * Fix Servo singularity scaling unit tests * Simplify tests * updateLinkTransforms is not needed after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the servo singularity scaling factor unit tests deterministic by initializing the full robot state (not just active positions) to default values before geting the Jacobian.