Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake error when building cached_ik_kinematics_plugin with trac_ik present #2421

Merged
merged 2 commits into from Oct 10, 2023
Merged

Fix CMake error when building cached_ik_kinematics_plugin with trac_ik present #2421

merged 2 commits into from Oct 10, 2023

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Oct 10, 2023 •
edited

This PR fixes this build error introduced by #2292, but uncaught because the trac_ik plugins are not tested in our CI:

The keyword signature for target_link_libraries has already been used with the target `moveit_cached_ik_kinematics_plugin`. 
All uses of target_link_libraries with a target must be either all-keyword or all-plain.

See this link for details why.

@sea-bass sea-bass self-assigned this Oct 10, 2023
@sea-bass sea-bass added the backport-iron Mergify label that triggers a PR backport to Iron label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9418678) 50.87% compared to head (602a68a) 50.87%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2421   +/-   ##
=======================================
  Coverage   50.87%   50.87%           
=======================================
  Files         386      386           
  Lines       31983    31983           
=======================================
  Hits        16269    16269           
  Misses      15714    15714

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit e37b956 into main Oct 10, 2023
11 checks passed
@sea-bass sea-bass deleted the fix-cached-trac-ik-build branch October 10, 2023 16:40
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@sea-bass @mergify
Fix CMake error when building cached_ik_kinematics_plugin with trac_i…
3fb8263 
…k present (#2421)

(cherry picked from commit e37b956)
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
henningkayser pushed a commit that referenced this pull request Oct 24, 2023
@mergify @sea-bass
Fix CMake error when building cached_ik_kinematics_plugin with trac_i…
ef20244 
…k present (backport #2421) (#2422)

(cherry picked from commit e37b956)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

@sjahr sjahr sjahr approved these changes

Assignees

@sea-bass sea-bass

Labels
backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sea-bass @ChrisThrasher @sjahr