Use node logging in moveit_ros #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 50.29% 50.31% +0.02%
==========================================
Files 391 391
Lines 31954 31982 +28
==========================================
+ Hits 16069 16087 +18
- Misses 15885 15895 +10
☔ View full report in Codecov by Sentry. |
tylerjw
force-pushed
the
node_logging
branch
2 times, most recently
from
8e215d8
to
4651a52
Compare
tylerjw
force-pushed
the
node_logging
branch
3 times, most recently
from
7ff165e
to
1b3860a
Compare
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
henningkayser
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Very clean refactoring. The changes are much less intrusive than I thought. Please update https://github.com/ros-planning/moveit2/blob/main/doc/MIGRATION_GUIDE.md before merging.
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Oct 30, 2023
Closed
moriarty
added a commit
to moriarty/moveit2
that referenced
this pull request
Nov 15, 2023
- This should fix ros-planning#2516 - Several moveit2 packages already depend on rsl - PR ros-planning#2482 added a depend in moveit_core This is only broken when building all of moveit2 deps in one colcon workspace And not using rosdep because colcon uses the package.xml and rsl might not have been built Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
6 tasks
sjahr
pushed a commit
that referenced
this pull request
Nov 15, 2023
- This should fix #2516 - Several moveit2 packages already depend on rsl - PR #2482 added a depend in moveit_core This is only broken when building all of moveit2 deps in one colcon workspace And not using rosdep because colcon uses the package.xml and rsl might not have been built Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the logger util library with some changes
I removed the assigning into the return of a function. It looks weird and I replaced it with a
set_loggerfunction.I added more static state so if
get_loggeris called beforeset_loggerit will still work as it will create amoveitnode. There might be a better way to do this. I did this so child loggers created without creating the base node would work. I added a test for the child logger without first assigning the node logger.