Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] threading issues in PSM and servo #257

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Aug 25, 2020

Description

Here are a couple of issues I found by building with thread sanitizer and running the servo tests.

@tylerjw
Copy link
Member Author

tylerjw commented Aug 25, 2020

This is failing CI for reasons that will be fixed by @AdamPettinger's next PR:

[test_servo_integration-3] Expected: (start_position) != (middle_position), actual: 0.0954851 vs 0.0954851

Copy link
Contributor

@AdamPettinger AdamPettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests and demos locally and they look good

These changes look good to me. As @tylerjw mentioned, I opened #258 to fix the test that failed here

@henningkayser henningkayser merged commit 4b40bd0 into moveit:master Aug 26, 2020
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants