Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 263 #276

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Enhancement 263 #276

merged 5 commits into from
Oct 15, 2020

Conversation

doitmaan
Copy link
Contributor

@doitmaan doitmaan commented Sep 9, 2020

Description

TIP

Replaced the redundant namespaces

robot_state::
robot_model::

with the actual namespace

moveit::core::

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #276 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   47.64%   47.64%           
=======================================
  Files         154      154           
  Lines       14844    14844           
=======================================
  Hits         7073     7073           
  Misses       7771     7771           
Impacted Files Coverage Δ
...bot_model/include/moveit/robot_model/robot_model.h 84.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a479df...735fe72. Read the comment docs.

@doitmaan doitmaan changed the title Enhancement 263 (TestInProgress) Enhancement 263 ( ***__~~TestInProgress~~__***) Sep 10, 2020
@doitmaan doitmaan changed the title Enhancement 263 ( ***__~~TestInProgress~~__***) Enhancement 263 Sep 10, 2020
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the namespaces altogether

@henningkayser henningkayser merged commit d8b5137 into moveit:main Oct 15, 2020
RoboticsYY pushed a commit to RoboticsYY/moveit2 that referenced this pull request Oct 21, 2020
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants