-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTC compatiblity fixes #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small questions. Overall looks good.
moveit_core/utils/include/moveit/utils/robot_model_test_utils.h
Outdated
Show resolved
Hide resolved
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 157 157
Lines 14843 14843
=======================================
Hits 7124 7124
Misses 7719 7719
Continue to review full report at Codecov.
|
This PR includes cherry-picked commits from Moveit 1 master, right? I think we should only apply your added fixes and run another sync to add the remaining changes. |
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/planning_scene_interface/src/planning_scene_interface.cpp
Outdated
Show resolved
Hide resolved
… duration to seconds
3caf2ef
to
a74262b
Compare
Description
These are some fixes for bugs I encountered while porting MTC
+ backported the first two commitsChecklist