Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to load move_group capabilities and controller manager #344

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Unable to load move_group capabilities and controller manager #344

merged 2 commits into from
Feb 5, 2021

Conversation

bostoncleek
Copy link
Contributor

@bostoncleek bostoncleek commented Jan 25, 2021

The cmake requires EXPORT the shared library under INSTALL
otherwise if building using colcon build --symlink-install will
fail to load the corresponding library. This issue has been fixed
for the moveit_ros_move_group and moveit_simple_controller_manager
packages.

Please see building a library.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check for symlink installs with CI?

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #344 (e98d437) into main (62f50a3) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   48.05%   47.90%   -0.15%     
==========================================
  Files         156      157       +1     
  Lines       14941    14874      -67     
==========================================
- Hits         7179     7124      -55     
+ Misses       7762     7750      -12     
Impacted Files Coverage Δ
...kinematic_constraints/src/kinematic_constraint.cpp 72.55% <0.00%> (-1.26%) ⬇️
moveit_core/utils/src/robot_model_test_utils.cpp 73.04% <0.00%> (-0.99%) ⬇️
moveit_ros/moveit_servo/src/servo_calcs.cpp 77.39% <0.00%> (-0.83%) ⬇️
...it_servo/include/moveit_servo/servo_parameters.cpp 60.83% <0.00%> (-0.39%) ⬇️
...bot_state/include/moveit/robot_state/robot_state.h 88.47% <0.00%> (-0.26%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 53.40% <0.00%> (-0.14%) ⬇️
...del/include/moveit/robot_model/joint_model_group.h 100.00% <0.00%> (ø)
...lude/moveit/collision_detection/collision_common.h 75.76% <0.00%> (ø)
...os/moveit_servo/include/moveit_servo/servo_calcs.h 100.00% <0.00%> (ø)
moveit_core/robot_state/src/robot_state.cpp 34.07% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f50a3...e97d87d. Read the comment docs.

…anager

The cmake requires `EXPORT` the shared library under `INSTALL`
otherwise if building using `colcon build --symlink-install` will
fail to load the corresponding library. This issue has been fixed
for the `moveit_ros_move_group` and `moveit_simple_controller_manager`
packages.
@henningkayser henningkayser merged commit 518fede into moveit:main Feb 5, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants