Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server timeout set to infinity #349

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Server timeout set to infinity #349

merged 1 commit into from
Jan 29, 2021

Conversation

bostoncleek
Copy link
Contributor

@bostoncleek bostoncleek commented Jan 27, 2021

By setting the timeout to infinity ensures the move group interface
is will be ready to use. This change is simply a ros2 migration
change.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #349 (5f72bfa) into main (d41811b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         157      157           
  Lines       14874    14874           
=======================================
  Hits         7124     7124           
  Misses       7750     7750           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41811b...5f72bfa. Read the comment docs.

By setting the timeout to infinity ensures the move group interface
is will be ready to use. This change is simply a ros2 migration
change.
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I meant. Thanks!

@henningkayser henningkayser merged commit e108c35 into moveit:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants