Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved small issue with a message not being logged due to early return #368

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

FlorisE
Copy link
Contributor

@FlorisE FlorisE commented Feb 18, 2021

Description

Tiny change. Due to wrong ordering of two lines in MoveItCpp::loadPlanningPipelines the function will return false when no planning pipelines are present, without logging this specific message.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #368 (b1ee767) into main (20c7d33) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   53.24%   53.26%   +0.02%     
==========================================
  Files         209      209              
  Lines       18856    18856              
==========================================
+ Hits        10038    10041       +3     
+ Misses       8818     8815       -3     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.82% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c7d33...b1ee767. Read the comment docs.

@JafarAbdi JafarAbdi merged commit c38b13e into moveit:main Feb 18, 2021
@brookdpg
Copy link

Ideally your IDE should tell you when code is unreachable.

MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Co-authored-by: Dave Coleman <dave@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants