Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialize function for moveit_sensor_manager plugin #386

Merged
merged 4 commits into from
Mar 26, 2021

Conversation

JafarAbdi
Copy link
Contributor

Description

Currently, there's no way to pass parameters to the sensor manager when creating it, so I added an initialize function similar to all other MoveIt plugins

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #386 (9d83a89) into main (2620f7b) will decrease coverage by 0.01%.
The diff coverage is 33.34%.

❗ Current head 9d83a89 differs from pull request most recent head f00259a. Consider uploading reports for the commit f00259a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   53.37%   53.37%   -0.00%     
==========================================
  Files         210      210              
  Lines       18814    18816       +2     
==========================================
+ Hits        10040    10041       +1     
- Misses       8774     8775       +1     
Impacted Files Coverage Δ
.../planning/plan_execution/src/plan_with_sensing.cpp 16.48% <33.34%> (-0.39%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.30% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2620f7b...f00259a. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 3f048b3 into moveit:main Mar 26, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <zelenak@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants