Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update move_group_launch_test_common.py to use projection_evaluator #470

Merged
merged 3 commits into from
May 20, 2021
Merged

Update move_group_launch_test_common.py to use projection_evaluator #470

merged 3 commits into from
May 20, 2021

Conversation

JafarAbdi
Copy link
Contributor

Description

As shown in the setup for the new OMPL constrained state space

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

henningkayser
henningkayser approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should this be part of moveit_resources?

@henningkayser henningkayser mentioned this pull request May 20, 2021
Merged
henningkayser
henningkayser requested changes May 20, 2021
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JafarAbdi that doesn't fix it yet

@henningkayser
Copy link
Member

@JafarAbdi that doesn't fix it yet

Actually, it does! But there was an upstream change in ros2_controllers that broke CI as well. Here is the fix for that moveit/moveit_resources#74. I'll merge this since the fix is trivial and I confirmed this to be working locally.

@henningkayser henningkayser merged commit aad154f into main May 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the JafarAbdi-patch-1 branch May 20, 2021 20:44
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
@tylerjw
Rename fake_components to mock_components (moveit#470)
215c771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JafarAbdi @henningkayser