[visualization] declare warehouse params in rviz plugin #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Motion planning plugin currently ignores parameters for warehouse_ros, because they are not declared yet. This can be verified by launching `ros2 launch run_move_group run_move_group.launch.py` (where some warehouse parameters like `warehouse_plugin` have to be defined before) and examinig the parameters with `ros2 param dump rviz2`.
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 45.20% 45.20%
=======================================
Files 169 169
Lines 18732 18732
=======================================
Hits 8465 8465
Misses 10267 10267 Continue to review full report at Codecov.
|
JafarAbdi
approved these changes
Jun 21, 2021
|
LGTM, but I'm not sure about the default values, what do you think @henningkayser @tylerjw .? |
tylerjw
approved these changes
Jun 21, 2021
JafarAbdi
added a commit
to JafarAbdi/moveit2
that referenced
this pull request
Jun 28, 2021
JafarAbdi
added a commit
to JafarAbdi/moveit2
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Motion planning plugin currently ignores parameters for warehouse_ros,
because they are not declared yet.
This can be verified by launching
ros2 launch run_move_group run_move_group.launch.py(where some warehouse parameters like
warehouse_pluginhave to be defined before)and examinig the parameters with
ros2 param dump rviz2.Checklist