Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh_shape: Fix resource group for meshes #672

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

JafarAbdi
Copy link
Contributor

Description

Fixes a bug causing RViz to print a ton of error messages about material not existing in the General resource group when adding a mesh to the planning scene

[rviz2-1] rviz2: Can't assign material Shape94Material to the ManualObject MeshShape_ManualObject0 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape96Material to the ManualObject MeshShape_ManualObject1 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape98Material to the ManualObject MeshShape_ManualObject2 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape100Material to the ManualObject MeshShape_ManualObject3 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape102Material to the ManualObject MeshShape_ManualObject4 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape104Material to the ManualObject MeshShape_ManualObject5 because this Material does not exist in group General. Have you forgotten to define it in a .material script?
[rviz2-1] rviz2: Can't assign material Shape106Material to the ManualObject MeshShape_ManualObject6 because this Material does not exist in group General. Have you forgotten to define it in a .material script?

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #672 (5099f70) into main (5ff36ac) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   54.38%   54.38%   +0.01%     
==========================================
  Files         191      191              
  Lines       20100    20100              
==========================================
+ Hits        10929    10930       +1     
+ Misses       9171     9170       -1     
Impacted Files Coverage Δ
...e/collision_detection_fcl/src/collision_common.cpp 74.64% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff36ac...5099f70. Read the comment docs.

@henningkayser henningkayser merged commit 97f1ea5 into moveit:main Sep 9, 2021
@JafarAbdi JafarAbdi deleted the pr-fix_mesh_rendering branch September 9, 2021 19:55
JafarAbdi added a commit to JafarAbdi/moveit2 that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants