Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getInterfaceDescription: Fix rclcpp API breakage #686

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

JafarAbdi
Copy link
Contributor

Description

ros2/rclcpp@679fb2b broke the API for async_send_request, so using response.get() multiple times will throw an exception std::future_error "No associated state"

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #686 (2b07fed) into main (0b27304) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files         192      192           
  Lines       20182    20182           
=======================================
  Hits        10931    10931           
  Misses       9251     9251           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b27304...2b07fed. Read the comment docs.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built and tested it and everything worked

@henningkayser henningkayser merged commit eec02c7 into moveit:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants