-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug print function for RobotTrajectory #715
Conversation
Signed-off-by: David V. Lu <davidvlu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 54.18% 54.22% +0.05%
==========================================
Files 192 192
Lines 20187 20227 +40
==========================================
+ Hits 10936 10966 +30
- Misses 9251 9261 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! I added a lot of feedback inline.
moveit_core/trajectory_processing/include/moveit/trajectory_processing/trajectory_tools.h
Outdated
Show resolved
Hide resolved
Old Output:
New Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! I definitely like the <<
overload
moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor nits, otherwise approve. Thank you for this.
moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
Outdated
Show resolved
Hide resolved
|
||
for (size_t p_i = 0; p_i < num_points; p_i++) | ||
{ | ||
const moveit::core::RobotState& point = getWayPoint(p_i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really finally implement moveit/moveit#1162 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it started #720
Co-authored-by: Tyler Weaver <tylerjw@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de>
97fcabe
to
7cd1d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
I guess you should rebase to get this merged without admin access. |
Signed-off-by: David V. Lu davidvlu@gmail.com
Description
The ability to print a trajectory is useful and should not be limited to the one set of tests.
Checklist