Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency from online_signal_smoothing cmake #839

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Dec 1, 2021

Description

This fixes this error:

CMake Error at online_signal_smoothing/CMakeLists.txt:49 (find_package):
  By not providing "Findros_testing.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "ros_testing", but CMake did not find one.

  Could not find a package configuration file provided by "ros_testing" with
  any of the following names:

    ros_testingConfig.cmake
    ros_testing-config.cmake

  Add the installation prefix of "ros_testing" to CMAKE_PREFIX_PATH or set
  "ros_testing_DIR" to a directory containing one of the above files.  If
  "ros_testing" provides a separate development package or SDK, be sure it
  has been installed.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to online_signal_smoothing instead

@tylerjw
Copy link
Member Author

tylerjw commented Dec 1, 2021

Should we add this to online_signal_smoothing instead

online_signal_smoothing is just a subdirectory of moveit_core.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #839 (7ef503d) into main (595813c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   57.79%   57.79%   +0.01%     
==========================================
  Files         305      305              
  Lines       26060    26060              
==========================================
+ Hits        15059    15060       +1     
+ Misses      11001    11000       -1     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 53.31% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595813c...7ef503d. Read the comment docs.

@tylerjw
Copy link
Member Author

tylerjw commented Dec 2, 2021

I found this when working on #842

moveit_core/package.xml Outdated Show resolved Hide resolved
@tylerjw tylerjw changed the title Add ros_testing dependency to moveit_core Remove unused dependency from online_signal_smoothing cmake Dec 8, 2021
@JafarAbdi JafarAbdi merged commit 84fffe9 into moveit:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants