Limit Variable Scope #874
Labels
good first issue
Good for newcomers
Comments
|
Hey! I would like to do this issue. |
SalahSoliman
added a commit
to SalahSoliman/moveit2
that referenced
this issue
Sep 15, 2022
Limited the scope of variables in moveit_core/collision_detection
|
hey i would like to do this issue |
Shobuj-Paul
pushed a commit
to Shobuj-Paul/moveit2
that referenced
this issue
Sep 5, 2023
Limited the scope of variables in moveit_core/collision_detection
Shobuj-Paul
pushed a commit
to Shobuj-Paul/moveit2
that referenced
this issue
Sep 11, 2023
Limited the scope of variables in moveit_core/collision_detection
Shobuj-Paul
pushed a commit
to Shobuj-Paul/moveit2
that referenced
this issue
Sep 12, 2023
Limited the scope of variables in moveit_core/collision_detection
Shobuj-Paul
pushed a commit
to Shobuj-Paul/moveit2
that referenced
this issue
Sep 14, 2023
Limited the scope of variables in moveit_core/collision_detection
tylerjw
pushed a commit
that referenced
this issue
Sep 14, 2023
* Limiting the scope of variables #874 Limited the scope of variables in moveit_core/collision_detection * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * convert float to double * change double to float * Feedback fixes * Introduced variables removed from previous merge commit * Updated GL_Renderer function definitions with double instead of float * Changed update() function arguments to float since it is a derived virtual function and needs to be overriden * Fixed all override errors in visualization * *Fixed override errors in perception *Changed reinterpret_cast to double* from float* * change variable types to fit function definition * Fixed clang-tidy warnings * Fixed scope of reusable variables --------- Co-authored-by: Salah Soliman <salahsoliman96@gmail.com> Co-authored-by: AndyZe <andyz@utexas.edu> Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this issue
Dec 4, 2023
* Limiting the scope of variables moveit#874 Limited the scope of variables in moveit_core/collision_detection * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/collision_detection/src/collision_octomap_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * convert float to double * change double to float * Feedback fixes * Introduced variables removed from previous merge commit * Updated GL_Renderer function definitions with double instead of float * Changed update() function arguments to float since it is a derived virtual function and needs to be overriden * Fixed all override errors in visualization * *Fixed override errors in perception *Changed reinterpret_cast to double* from float* * change variable types to fit function definition * Fixed clang-tidy warnings * Fixed scope of reusable variables --------- Co-authored-by: Salah Soliman <salahsoliman96@gmail.com> Co-authored-by: AndyZe <andyz@utexas.edu> Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/cpp-best-practices/cppbestpractices/blob/master/08-Considering_Performance.md#limit-variable-scope
The text was updated successfully, but these errors were encountered: