Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed post-increments in loops to preincrements #888

Merged
merged 6 commits into from
Dec 13, 2021

Conversation

senceryazici
Copy link
Contributor

Description

Post incremented variables in loops are replaced with pre incremented variables, as suggested by #870.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. CI is failing for a known issue that should be fixed soon.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #888 (9b77919) into main (0b908a1) will not change coverage.
The diff coverage is 59.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #888   +/-   ##
=======================================
  Coverage   57.91%   57.91%           
=======================================
  Files         310      310           
  Lines       26072    26072           
=======================================
  Hits        15096    15096           
  Misses      10976    10976           
Impacted Files Coverage Δ
...on_distance_field/collision_distance_field_types.h 59.41% <0.00%> (ø)
moveit_core/distance_field/src/distance_field.cpp 26.01% <0.00%> (ø)
...cessing/src/time_optimal_trajectory_generation.cpp 77.50% <0.00%> (ø)
...mpl/ompl_interface/src/detail/ompl_constraints.cpp 0.00% <0.00%> (ø)
...ution_manager/src/trajectory_execution_manager.cpp 6.77% <0.00%> (ø)
...it_ros/robot_interaction/src/robot_interaction.cpp 0.00% <0.00%> (ø)
...ance_field/src/collision_common_distance_field.cpp 25.97% <14.29%> (ø)
...tance_field/src/collision_distance_field_types.cpp 35.84% <58.83%> (ø)
...istance_field/src/collision_env_distance_field.cpp 54.06% <60.53%> (ø)
...it/collision_detection/test_collision_common_pr2.h 98.18% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b908a1...9b77919. Read the comment docs.

@tylerjw tylerjw merged commit 4cbd1a7 into moveit:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants