Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost linking errors #900

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

vatanaksoytezer
Copy link
Contributor

There were some weird boost linking errors since yesterday, I was able to reproduce by running industrial_ci locally, and this PR should hopefully fix them. I have yet to know the root cause, so I'm happy to resolve this different ways as well if someone has any suggestion.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #900 (c9d2823) into main (595813c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   57.79%   57.79%           
=======================================
  Files         305      305           
  Lines       26060    26060           
=======================================
  Hits        15059    15059           
  Misses      11001    11001           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fffe9...c9d2823. Read the comment docs.

@tylerjw tylerjw merged commit f48de7d into moveit:main Dec 9, 2021
@vatanaksoytezer vatanaksoytezer added the backport-foxy Mergify label that triggers a PR backport to Foxy label Dec 14, 2021
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
(cherry picked from commit f48de7d)
tylerjw pushed a commit that referenced this pull request Dec 14, 2021
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
@lilustga
Copy link
Contributor

I noticed that moveit_core already includes Boost regex and iostreams in ConfigExtras.cmake. I think however, it is being overwritten by this change in geometric_shapes: moveit/geometric_shapes#206

@tylerjw What do you think of instead moving include(ConfigExtras.cmake) to after find_package is called for geometric shapes?

@tylerjw
Copy link
Member

tylerjw commented Jan 14, 2022

I think there is a new PR that fixes that already. @JafarAbdi is going to copy that pattern of calling include after the find package lines to the rest of MoveIt and then we'll merge it.

bijoua29 pushed a commit to SchillingRobotics/moveit2 that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-foxy Mergify label that triggers a PR backport to Foxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants