Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell to precommit, fix A LOT of spelling mistakes #934

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Dec 21, 2021

Description

As requested here: moveit/moveit2_tutorials#244

We add the codespell module to .pre-commit-config.yaml and then fix a bunch of spelling errors.

Top Spelling Errors Seen

19 occured/occurred
12 seperator/separator
9 sceen/screen
9 succesfully/successfully
8 postion/position
6 Reenable/Re-enable
5 collison/collision
4 Containter/Container

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome thanks for doing this David.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #934 (7c23e1a) into main (ec6a2e1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   57.91%   57.90%   -0.00%     
==========================================
  Files         310      310              
  Lines       26067    26067              
==========================================
- Hits        15093    15092       -1     
- Misses      10974    10975       +1     
Impacted Files Coverage Δ
...lude/moveit/collision_detection/collision_common.h 80.00% <ø> (ø)
...ion_bullet/bullet_integration/bullet_bvh_manager.h 0.00% <ø> (ø)
...ullet/bullet_integration/bullet_cast_bvh_manager.h 100.00% <ø> (ø)
...t/bullet_integration/bullet_discrete_bvh_manager.h 100.00% <ø> (ø)
...detection_bullet/bullet_integration/bullet_utils.h 89.79% <ø> (ø)
...bullet/bullet_integration/contact_checker_common.h 100.00% <ø> (ø)
...src/bullet_integration/bullet_cast_bvh_manager.cpp 50.73% <ø> (ø)
.../src/bullet_integration/contact_checker_common.cpp 84.06% <ø> (ø)
...on_distance_field/collision_distance_field_types.h 59.41% <ø> (ø)
...eit/constraint_samplers/union_constraint_sampler.h 30.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6a2e1...7c23e1a. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

@tylerjw tylerjw merged commit 0140b7e into moveit:main Dec 21, 2021
@DLu DLu deleted the codespell branch February 11, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants