-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax #939
Fix syntax #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow indeed, I should investigate why CI didn't catch this.
But this hp_action_client_ = rclcpp_action::create_client<moveit_msgs::action::HybridPlanner>(node_, "run_hybrid_planning"), builds in my local setup too, so maybe CI is fine. |
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
==========================================
+ Coverage 57.91% 57.91% +0.01%
==========================================
Files 310 310
Lines 26069 26069
==========================================
+ Hits 15095 15096 +1
+ Misses 10974 10973 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It builds fine because similarly, this is valid c++ syntax:
a = 2, b = 3;
The comma operator can be used to separate multiple assignment statements, there is no requirement that you have to put a semi-colon at the end of a line, only that you have to finish each statement with them.
SO post about comma operator: https://stackoverflow.com/questions/4352857/what-is-a-comma-separated-set-of-assignments
Ahh, thanks for making this clear, I totally forgot about this syntax option. Should we merge it anyways for uniformity and to avoid further confusion? |
Description
Replace a comma with a semicolon. I am a little bit confused, why did this build before and why doesn't CI complain about this?
Checklist