Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveIt visualization bug fixes #168

Merged
merged 2 commits into from
Feb 9, 2020

Conversation

JafarAbdi
Copy link
Contributor

Description

This fixes two bugs

1- Using the name of the SceneNode was throwing an exception in the destructor see Mike's comment
2- Having an empty robot description will pass an empty string to rdf_loader which will cause it to throw an empty parameter name exception

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi JafarAbdi mentioned this pull request Feb 5, 2020
6 tasks
@mlautman
Copy link
Contributor

mlautman commented Feb 5, 2020

I still think that the robot_description should be able to come from either a parameter, topic, or file like the RobotModelDisplay. Just using parameters doesn't make that much sense as it requires Rviz to be launched with special arguments

@henningkayser henningkayser merged commit 9f68c3b into moveit:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants