-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify controller name in MGI execution #2257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanie-eng
changed the title
Draft: Specify controller name in MGI execute
Draft: Specify controller name in MGI execution
Jun 30, 2023
stephanie-eng
force-pushed
the
seng/controller_name_mgi
branch
from
July 19, 2023 17:29
4ef42e3
to
9179740
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
- Coverage 50.51% 50.50% -0.01%
==========================================
Files 386 386
Lines 31732 31732
==========================================
- Hits 16026 16022 -4
- Misses 15706 15710 +4 ☔ View full report in Codecov by Sentry. |
stephanie-eng
changed the title
Draft: Specify controller name in MGI execution
Specify controller name in MGI execution
Jul 19, 2023
sea-bass
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, save one minor comment -- so LGTM!
...ng_interface/move_group_interface/include/moveit/move_group_interface/move_group_interface.h
Outdated
Show resolved
Hide resolved
sjahr
approved these changes
Jul 25, 2023
sea-bass
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1632
This PR adds the ability to execute via MGI while specifying a controller name. This can be useful for more fine control over controller-switching applications for which multiple controllers apply, and it is undesirable to let TrajectoryExecutionManager selet the controller for you.
Related and required change in moveit_msgs: moveit/moveit_msgs#160