Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify controller name in MGI execution #2257

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Jun 29, 2023

Resolve #1632

This PR adds the ability to execute via MGI while specifying a controller name. This can be useful for more fine control over controller-switching applications for which multiple controllers apply, and it is undesirable to let TrajectoryExecutionManager selet the controller for you.

Related and required change in moveit_msgs: moveit/moveit_msgs#160

@stephanie-eng stephanie-eng changed the title Draft: Specify controller name in MGI execute Draft: Specify controller name in MGI execution Jun 30, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6eebe6c) 50.51% compared to head (237c3c0) 50.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
- Coverage   50.51%   50.50%   -0.01%     
==========================================
  Files         386      386              
  Lines       31732    31732              
==========================================
- Hits        16026    16022       -4     
- Misses      15706    15710       +4     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanie-eng stephanie-eng marked this pull request as ready for review July 19, 2023 19:11
@stephanie-eng stephanie-eng changed the title Draft: Specify controller name in MGI execution Specify controller name in MGI execution Jul 19, 2023
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, save one minor comment -- so LGTM!

@sjahr sjahr enabled auto-merge (squash) July 25, 2023 18:40
@sjahr sjahr merged commit cdf7a98 into moveit:main Jul 25, 2023
7 of 8 checks passed
@sea-bass sea-bass mentioned this pull request Jul 27, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying controllers when executing a plan via move group
3 participants