Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jogging drift dimensions #63

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Change jogging drift dimensions #63

merged 6 commits into from
Feb 6, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Jan 21, 2020

Very similar to PR #61

#61 defines a service to set velocities in certain dimensions to 0.

This PR defines a service to allow the robot to drift in a smooth but unregulated way (in the specified dimensions). In preparation to take advantage of task redundancy.

@davetcoleman
Copy link
Member

Does this support drifting in non-axis aligned vectors / directions?

@AndyZe
Copy link
Member Author

AndyZe commented Jan 21, 2020

Does this support drifting in non-axis aligned vectors / directions?

Not as I imagine the implementation currently. I can imagine how you would achieve that but it's beyond the scope of what I was hoping to add.

Edit - you could achieve that by adding a new tf frame and setting that frame as the jog_arm control frame. So yes, that could be done.

@davetcoleman
Copy link
Member

If instead of bool, we used float, wouldn't that allow more control over how much in each direction you could float? And maybe accomplish arbitrary angles? I'm not really sure, but requiring axis-aligned seems short-sighted for this moveit_msgs API

@AndyZe
Copy link
Member Author

AndyZe commented Jan 21, 2020

If instead of bool, we used float, wouldn't that allow more control over how much in each direction you could float?

Well it's a binary thing. Either the Jacobian row is present or it isn't, so I don't think a float would help.

The way you get a different axis would be transforming the Jacobian.

@AndyZe
Copy link
Member Author

AndyZe commented Jan 22, 2020

Does this support drifting in non-axis aligned vectors / directions?

I think this would be implemented better by adding a function to change the jog_arm command frame at runtime.

@davetcoleman
Copy link
Member

davetcoleman commented Jan 22, 2020

Could we add a frame (pose) to this message that would support non-axis aligned? Even if you don't use it yet (we could note its not implemented yet)

@AndyZe AndyZe changed the title Change free dimensions Change jogging drift dimensions Jan 22, 2020
@AndyZe
Copy link
Member Author

AndyZe commented Jan 22, 2020

How about adding a geometry_msgs/Transform, and we can assume it will be relative to the jogging command frame?

@davetcoleman
Copy link
Member

sgtm

@davetcoleman
Copy link
Member

@bmagyar your thoughts are welcome!

Co-Authored-By: Dave Coleman <dave@picknik.ai>
@davetcoleman davetcoleman merged commit a40198a into moveit:master Feb 6, 2020
tylerjw pushed a commit to tylerjw/moveit_msgs that referenced this pull request May 4, 2020
* Add service file to control moveit_jog_arm free dimensions

* A better-sounding description

* Change service name to ChangeDriftDimensions

* Reword control_x_translation -> drift_x_translation

* Add a transform to the service

* Update srv/ChangeDriftDimensions.srv comment

Co-Authored-By: Dave Coleman <dave@picknik.ai>

Co-authored-by: Dave Coleman <dave@picknik.ai>
mamoll pushed a commit that referenced this pull request May 6, 2020
* Added service file for moveit_experimental/moveit_jog_arm

* Update srv/ChangeControlDimensions.srv

Co-Authored-By: Dave Coleman <dave@picknik.ai>

* Change jogging drift dimensions (#63)

* Add service file to control moveit_jog_arm free dimensions

* A better-sounding description

* Change service name to ChangeDriftDimensions

* Reword control_x_translation -> drift_x_translation

* Add a transform to the service

* Update srv/ChangeDriftDimensions.srv comment

Co-Authored-By: Dave Coleman <dave@picknik.ai>

Co-authored-by: Dave Coleman <dave@picknik.ai>

Co-authored-by: AdamPettinger <adam.pettinger@utexas.edu>
Co-authored-by: Dave Coleman <dave@picknik.ai>
Co-authored-by: AndyZe <andyz@utexas.edu>
@tylerjw tylerjw mentioned this pull request May 8, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants