-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change jogging drift dimensions #63
Conversation
Does this support drifting in non-axis aligned vectors / directions? |
Edit - you could achieve that by adding a new tf frame and setting that frame as the jog_arm control frame. So yes, that could be done. |
If instead of bool, we used |
Well it's a binary thing. Either the Jacobian row is present or it isn't, so I don't think a The way you get a different axis would be transforming the Jacobian. |
I think this would be implemented better by adding a function to change the jog_arm command frame at runtime. |
Could we add a frame (pose) to this message that would support non-axis aligned? Even if you don't use it yet (we could note its not implemented yet) |
How about adding a geometry_msgs/Transform, and we can assume it will be relative to the jogging command frame? |
sgtm |
@bmagyar your thoughts are welcome! |
Co-Authored-By: Dave Coleman <dave@picknik.ai>
* Add service file to control moveit_jog_arm free dimensions * A better-sounding description * Change service name to ChangeDriftDimensions * Reword control_x_translation -> drift_x_translation * Add a transform to the service * Update srv/ChangeDriftDimensions.srv comment Co-Authored-By: Dave Coleman <dave@picknik.ai> Co-authored-by: Dave Coleman <dave@picknik.ai>
* Added service file for moveit_experimental/moveit_jog_arm * Update srv/ChangeControlDimensions.srv Co-Authored-By: Dave Coleman <dave@picknik.ai> * Change jogging drift dimensions (#63) * Add service file to control moveit_jog_arm free dimensions * A better-sounding description * Change service name to ChangeDriftDimensions * Reword control_x_translation -> drift_x_translation * Add a transform to the service * Update srv/ChangeDriftDimensions.srv comment Co-Authored-By: Dave Coleman <dave@picknik.ai> Co-authored-by: Dave Coleman <dave@picknik.ai> Co-authored-by: AdamPettinger <adam.pettinger@utexas.edu> Co-authored-by: Dave Coleman <dave@picknik.ai> Co-authored-by: AndyZe <andyz@utexas.edu>
Very similar to PR #61
#61 defines a service to set velocities in certain dimensions to 0.
This PR defines a service to allow the robot to drift in a smooth but unregulated way (in the specified dimensions). In preparation to take advantage of task redundancy.