Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use moveit repo's travis config #47

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Use moveit repo's travis config #47

merged 5 commits into from
Jul 2, 2019

Conversation

davetcoleman
Copy link
Member

Currently travis is failing

@davetcoleman davetcoleman mentioned this pull request Apr 22, 2019
Merged
henningkayser
henningkayser reviewed May 2, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@rhaschke
Copy link
Contributor

rhaschke commented May 2, 2019

Building this together with latest MoveIt exhausts the time limit provided by Travis, particularly when running clang-tidy. I suggest building this repo against the MoveIt source container, which ensures that we check against the latest MoveIt source, but dramatically speed up the Travis check.
Corresponding changes to moveit_ci (moveit/moveit_ci#62) and the source docker container (moveit/moveit#1451) are prepared and intended to be used for moveit/moveit_tutorials#317 as well.

@rhaschke rhaschke mentioned this pull request May 2, 2019
Merged
rhaschke
rhaschke previously requested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #47 (comment).

@davetcoleman
Copy link
Member Author

@rhaschke i like that plan. can you make a PR to this PR, or just open another one?

@rhaschke
Copy link
Contributor

rhaschke commented May 14, 2019 •
edited
Loading

@davetcoleman I pushed a proposal to clean up .travis.yml.
As it seems, you wanted to enable clang-tidy for this repo as well, I applied the required fixes...
This PR now relies on moveit/moveit#1464, moveit/moveit#1465, and moveit/moveit_ci#66.

@rhaschke rhaschke dismissed their stale review May 14, 2019 14:59

I pushed corrections myself, so dismissing my original review.

@rhaschke rhaschke force-pushed the upgrade_travis branch 2 times, most recently from f75ed77 to e96494f Compare May 14, 2019 18:52
@rhaschke
Copy link
Contributor

This branch cannot be compiled on Kinetic (against kinetic-devel branch of MoveIt) anymore. It's only possible to build against melodic-devel or master of MoveIt. Do you really want to test this master branch against Kinetic as well (as indicated in #47 (comment))?

@davetcoleman
Copy link
Member Author

Do you really want to test this master branch against Kinetic as well (as indicated in #47 (comment))?

It would be best if we still tested against Ubuntu 16.04, but no need to test against MoveIt Kinetic. Does that make sense and how hard would that be?

@rhaschke rhaschke force-pushed the upgrade_travis branch 2 times, most recently from 206be03 to f200ca0 Compare May 31, 2019 21:26
@rhaschke
cleanup .travis.yml
97565cf 
- For Melodic, use source container as ROS underlay to avoid building MoveIt.
- For Kinetic, build MoveIt master branch too.
@rhaschke
apply clang-tidy fixes
82f4f4f 
- use const references where possible
- simply return of booleans
@rhaschke
use compile-time switches to disable/enable code blocks
c41461a
@rhaschke
fix remaining compiler warnings
236aeed 
- order of member initialization
- unused variables
@rhaschke
clang-format
72678ef
@rhaschke
Copy link
Contributor

rhaschke commented Jun 1, 2019

It would be best if we still tested against Ubuntu 16.04, but no need to test against MoveIt Kinetic.

@davetcoleman, I modified the Travis config to build MoveIt as well on 16.04.
Please perform a true merge commit for keeping the full commit history.

@rhaschke rhaschke mentioned this pull request Jul 2, 2019
Merged
davetcoleman
davetcoleman commented Jul 2, 2019
View reviewed changes
Copy link
Member Author

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks @rhaschke !

@davetcoleman
Copy link
Member Author

+1

@davetcoleman davetcoleman merged commit dbbf3a6 into master Jul 2, 2019
@rhaschke rhaschke deleted the upgrade_travis branch July 3, 2019 04:56
rhaschke pushed a commit that referenced this pull request Jul 3, 2019
@davetcoleman @rhaschke
Fix Travis config + issues (#47)
bd65906 
* cleanup .travis.yml
  - For Melodic, use source container as ROS underlay to avoid building MoveIt.
  - For Kinetic, build MoveIt master branch too.

* apply clang-tidy fixes
  - use const references where possible
  - simply return of booleans

* use compile-time switches to disable/enable code blocks

* clang-format

* fix remaining compiler warnings
  - order of member initialization
  - unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser left review comments

@rhaschke rhaschke rhaschke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davetcoleman @rhaschke @henningkayser