Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first trajectory point as start state for visualization #49

Merged

Conversation

henningkayser
Copy link
Member

When visualizing trajectories of subgroups the previous implementation would use the shared initial robot state for populating the joint values outside the group. This can have strange effects like apparent link collisions even though the original trajectory is collision free. If we have a robot trajectory with fully populated robot states we should use these instead.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks good to me, perhaps you could still emit a warning or an info message that the start state should be defined.

@bmagyar
Copy link
Member

bmagyar commented Jun 14, 2019

I've restarted the CI jobs, 3/3 "succeeded", 2/3 failed on a post-build timeout :-/

@davetcoleman
Copy link
Member

Travis error:

moveit_ros/perception/mesh_filter/test/mesh_filter_test.cpp

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked into the failing GPU test?

@davetcoleman
Copy link
Member

@henningkayser can you compare .travis.yml from /moveit repo to this repo? maybe there are some changes we need to bring in to fix travis?

@rhaschke
Copy link
Contributor

rhaschke commented Jul 2, 2019

@henningkayser can you compare .travis.yml from /moveit repo to this repo?

@davetcoleman, there is an open PR (#47) to address the Travis issues waiting for your approval since a month or so.

@davetcoleman
Copy link
Member

I had forgot about that PR, thanks Robert!

@rhaschke
Copy link
Contributor

rhaschke commented Jul 3, 2019

Closing & re-opening to trigger Travis rebuild.

@rhaschke rhaschke closed this Jul 3, 2019
@rhaschke rhaschke reopened this Jul 3, 2019
@rhaschke rhaschke merged commit 883beb7 into moveit:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants