Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS-O] various patches #1225

Merged
merged 3 commits into from Nov 9, 2022
Merged

Conversation

v4hn
Copy link
Member

@v4hn v4hn commented Nov 9, 2022

required to build on current Debian.

this breaks with current versions of log4cxx.
the non-hpp headers have been deprecated since kinetic
Using boost's _1 as a global system is deprecated since C++11.
The ROS packages in Debian removed the implicit support for the global symbols,
so this code fails to compile there without the patch.
Copy link
Contributor

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI to pass

@mikeferguson mikeferguson merged commit f94f7b0 into ros-planning:noetic-devel Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants