Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is move_base's parameter clearing_rotation_allowed actually working? #38

Closed
corot opened this issue May 7, 2013 · 6 comments
Closed

Comments

@corot
Copy link
Contributor

corot commented May 7, 2013

Setting clearing_rotation_allowed parameter as false doesn't prevent the robot to make in place rotations as it's supposed to do (to my understanding of the wiki documentation). In fact, it looks like the parameter value has no effect at all.

There'is any problem or I misunderstood the use of this parameter?

@hershwg
Copy link
Contributor

hershwg commented May 7, 2013

From the wiki (and confirmed by reading the source code):

"clearing_rotation_allowed (bool, default: true): Determines whether or not the robot will attempt an in-place rotation when attempting to clear out space. Note: This parameter is only used when the default recovery behaviors are in use, meaning the user has not set the recovery_behaviors parameter to anything custom."

If you have a "recovery_behaviors" section in your move_base parameters, that makes clearing_rotation_allowed be ignored. If you have such a section and it contains a recovery behavior called "rotate_recovery" then just take it out.

However, I will say that sadly there are tons of situations that can make a robot just rotate in place which are not related to rotate_recovery. Eliminating all of them is a subject too long for this bug discussion.

@corot
Copy link
Contributor Author

corot commented May 8, 2013

mmm.... but I'm using default recovery behaviors, and the log says "rotating to clear costmap" or something like this, so I think is a recovery behavior what makes the robot spins.

@hershwg
Copy link
Contributor

hershwg commented May 8, 2013

Well OK then! :) Sorry, I didn't realize how clear your situation was.

What version of move_base are you running?

@hershwg
Copy link
Contributor

hershwg commented May 8, 2013

Looks like it is a spelling error in the code. The code is waiting for "clearing_roatation_allowed". Sigh.

@corot
Copy link
Contributor Author

corot commented May 9, 2013

Cool! it will be very useful to me. Do u want me to do a pull request?

Btw, I use hydro-devel sources.

@hershwg
Copy link
Contributor

hershwg commented May 9, 2013

You can use it right away by misspelling the parameter in your rosparams the same way it is misspelled in the code. I'll get a fix in later today.

corot added a commit to corot/navigation that referenced this issue Jun 19, 2013
@hershwg hershwg closed this as completed Jul 3, 2013
nlimpert pushed a commit to nlimpert/navigation that referenced this issue Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants