Cleanup PCL imports: fixes compilation on zesty and stretch #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triggering CI |
|
LGTM -- waiting for CI to complete, and then I'd like to merge this BEFORE #591 (which will then require a fixup) |
|
I'm not sure how that test failure would occur with build change... but this is changing the related package, so I think we need to look into that |
|
Closed involuntarily this PR. The new CI launched when reopening seems to be green, so I dont think that the failure seen in http://build.ros.org/job/Lpr__navigation__ubuntu_xenial_amd64/5/ is related to this PR |
|
Thanks for retriggering again -- looking over things it looks like that test is failing intermittently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more elegant alternative to #578 , this fixes compilation errors on Zesty and Stretch.
It also allow to reduce the amount of PCL libraries these packages link against and add missing dependencies on pcl for packages using it.