New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to package format 2 #591
Convert to package format 2 #591
Conversation
@@ -1,4 +1,6 @@ | |||
<package> | |||
<?xml version="1.0"?> | |||
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honest question: since when is this a thing?
I'm not sure if the question applies to format 2 or the fact of providing a reference to the schema in an xml header. So I'll try to answer both, keeping in mind that both preceded my involvement with ROS or xml parsers. package format 2 has been introduced in 2013-2014 to provide a format more adapted to the catkin build system, some advantages being being less verbose than the first version by adding the xml schema : AFAIU it is recommended since 2001 to provide a formal definition in xsd format to allow to write/generate complete parsers for a specific xml format. Hope this provides more context. Note: I understand that this PR may conflict with numerous existing ones and may stay on hold for a bit. |
@ros-pull-request-builder retest this please. |
looks like CI is failing because |
0e941d8
to
bddb188
Compare
@mikeferguson I just rebased this PR on latest lunar. I'm still unsure about #591 (comment), let me know if their is any change necessary |
I'm aiming to get one more thing in before this: #596 (which brings forward some of the same fixes you have here, but also fixes a number of CMake issues). |
Ok, I'm done totally destroying your pull request for a little while -- if you can rebase (and maybe there might be some fixups required?) we can get this in next. |
bddb188
to
2610594
Compare
rebased and resolved conflict. CI has been interrupted a few times but looks promising so far |
Thanks! I'll do a new release into lunar in the morning |
No description provided.