Adding simulation time parameter for the controller manager #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the simulation parameter so that the controller manager uses the simulation time instead of the ROS time. The '/odom' and corresponding tf will only be published if this parameter is set to true.
eslamsalahelsheikh
changed the title
|
I don't understand this. This shouldn't affect the publication of anything. Are you sure that you are checking the correct setup? If yes, please elaborate on the exact behavior. |
Hi Denis, you can verify this easily if you run the diff_drive example with same setup you have here and check if there is anything published on the "/odom" topic |
|
OK, I see this. Not sure if this should be also fixed in the diff drive controller in general. But you are right this is at least fastest solution for now and probably will cover a lot of use-cases. Thanks! |
destogl
approved these changes
Jun 28, 2022
ahcorde
added a commit
to ahcorde/rosdistro
that referenced
this pull request
Jul 5, 2022
Increasing version of package(s) in repository `gazebo_ros2_control` to `0.3.1-1`: - upstream repository: https://github.com/ros-simulation/gazebo_ros2_control.git - release repository: https://github.com/ros2-gbp/gazebo_ros2_control-release.git - distro file: `rolling/distribution.yaml` - bloom version: `0.11.1` - previous version for package: `0.3.0-1` ``` * Added logic for activating hardware interfaces (ros#139 <ros-controls/gazebo_ros2_control#139>) * Adjust repo URL (ros#134 <ros-controls/gazebo_ros2_control#134>) * Contributors: Alejandro Hernández Cordero, Bence Magyar ``` ``` * Fixed CMake source file extension (ros#140 <ros-controls/gazebo_ros2_control#140>) * Adding simulation time parameter for the controller manager (ros#138 <ros-controls/gazebo_ros2_control#138>) Adding the simulation parameter so that the controller manager uses the simulation time instead of the ROS time. The '/odom' and corresponding tf will only be published if this parameter is set to true. * Adjust repo URL (ros#134 <ros-controls/gazebo_ros2_control#134>) * Changed launch variable name (ros#130 <ros-controls/gazebo_ros2_control#130>) * Contributors: Alejandro Hernández Cordero, Bence Magyar, Eslam Salah, Jakub "Deli" Delicat ``` Signed-off-by: ahcorde <ahcorde@gmail.com>
tfoote
pushed a commit
to ros/rosdistro
that referenced
this pull request
Jul 7, 2022
…33784) Increasing version of package(s) in repository `gazebo_ros2_control` to `0.3.1-1`: - upstream repository: https://github.com/ros-simulation/gazebo_ros2_control.git - release repository: https://github.com/ros2-gbp/gazebo_ros2_control-release.git - distro file: `rolling/distribution.yaml` - bloom version: `0.11.1` - previous version for package: `0.3.0-1` ``` * Added logic for activating hardware interfaces (#139 <ros-controls/gazebo_ros2_control#139>) * Adjust repo URL (#134 <ros-controls/gazebo_ros2_control#134>) * Contributors: Alejandro Hernández Cordero, Bence Magyar ``` ``` * Fixed CMake source file extension (#140 <ros-controls/gazebo_ros2_control#140>) * Adding simulation time parameter for the controller manager (#138 <ros-controls/gazebo_ros2_control#138>) Adding the simulation parameter so that the controller manager uses the simulation time instead of the ROS time. The '/odom' and corresponding tf will only be published if this parameter is set to true. * Adjust repo URL (#134 <ros-controls/gazebo_ros2_control#134>) * Changed launch variable name (#130 <ros-controls/gazebo_ros2_control#130>) * Contributors: Alejandro Hernández Cordero, Bence Magyar, Eslam Salah, Jakub "Deli" Delicat ``` Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
Nov 7, 2022
Adding the simulation parameter so that the controller manager uses the simulation time instead of the ROS time. The '/odom' and corresponding tf will only be published if this parameter is set to true.
bmagyar
added a commit
that referenced
this pull request
Nov 15, 2022
ahcorde
added a commit
that referenced
this pull request
Nov 21, 2022
* fix maintainer email (#92) Signed-off-by: ahcorde <ahcorde@gmail.com> * CHANGELOG Signed-off-by: ahcorde <ahcorde@gmail.com> * 0.0.4 * 0.0.5 * Update Foxy dockerfile (#101) Signed-off-by: ahcorde <ahcorde@gmail.com> * Declare dependency of gazebo_hardware_plugins to urdf in CMakeLists.txt (#117) (#119) Co-authored-by: Martin Wudenka <Martin.Wudenka@gmx.de> * Added diff drive example (#113) Signed-off-by: ahcorde <ahcorde@gmail.com> * changelog Signed-off-by: ahcorde <ahcorde@gmail.com> * 0.1.0 * [backport Foxy] #136 #147 #139 #134 (#150) * Implemented perform_command_mode_switch override in GazeboSystem (#136) * added namespace to controller manager (#147) * Added logic for activating hardware interfaces (#139) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Keegan Sotebeer <ksotebeer95@gmail.com> Co-authored-by: Maciej Bednarczyk <83034299+mcbed@users.noreply.github.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> * [Backport Foxy] Support for mimic joints and example with gripper. (#121) * [Backport Foxy] Support for mimic joints and example with gripper. * Enable loading params from multiple yaml files (#149) (#151) Co-authored-by: Tony Najjar <tony.najjar@logivations.com> * Adding simulation time parameter for the controller manager (#138) (#158) Co-authored-by: Eslam Salah <eslamsalahelsheikh@gmail.com> * Changelog Signed-off-by: ahcorde <ahcorde@gmail.com> * 0.1.1 * Add pre-commit hooks configuration (#161) * Add pre-commit hooks configuration Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Pre-commit in a separate action Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix codespell Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Martin Wudenka <Martin.Wudenka@gmx.de> Co-authored-by: Keegan Sotebeer <ksotebeer95@gmail.com> Co-authored-by: Maciej Bednarczyk <83034299+mcbed@users.noreply.github.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Tony Najjar <tony.najjar@logivations.com> Co-authored-by: Eslam Salah <eslamsalahelsheikh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the simulation parameter so that the controller manager uses the simulation time instead of the ROS time. The '/odom' and corresponding tf will only be published if this parameter is set to true.