Fix STL iterator errors, misc. cppcheck (#182) #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some errors in STL iterators. Initialized values of member variables in constructor. Removed an unused variable (model_name).
|
@adolfo-rt I think you initially submitted the patch to drcsim that this pr is based on (see #182 and drcsim issue 162). |
It's likely, yes. I remember submitting a fix once as Anonymous by mistake. Is there an issue with the proposed fixes?. |
|
That patch was submitted to drcsim when drcsim had a fork of some of the gazebo_plugins. This pull request brings those fixes to gazebo_plugins. EDIT: No, there's no issues, just waiting for normal code review. |
|
looks good. |
hsu
added a commit
that referenced
this pull request
Aug 29, 2014
Fix STL iterator errors, misc. cppcheck (#182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some errors in STL iterators.
Initialized values of member variables in constructor.
Removed an unused variable (model_name).
Use prefix ++.
Fixes #182.