Fix issue #690 add physics type for dart with joint velocity interface #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change seems to be failing in gazebo7: https://build.osrfoundation.org/job/ros_gazebo_pkgs-ci-pr_any_kinetic-xenial-amd64/98/console We probably need to add a ifdef on the GAZEBO version lower than 8 to adapt to the official API of Kinetic (gazebo7). Could you please add it? |
jacknlliu
force-pushed
the
fix-vel-interface-for-dart
branch
from
1f9c677
to
e8213c9
Compare
|
|
The errors in CI are not related to this PR. Thanks for the contribution! |
Roboterbastler
pushed a commit
to Roboterbastler/gazebo_ros_pkgs
that referenced
this pull request
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #690
SetParam("vel")toSetVelocity()for dart physics engine