Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][melodic-devel] more Windows build break fix #975

Merged
merged 2 commits into from
Aug 8, 2019
Merged

[Windows][melodic-devel] more Windows build break fix #975

merged 2 commits into from
Aug 8, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Aug 8, 2019

More Windows build break fix.

@seanyen
Copy link
Contributor Author

seanyen commented Aug 8, 2019

@chapulina @j-rivero I am planning to swap https://ms-iot.github.io/ROSOnWindows/Build/buildfarm.html to use upstream gazebo_ros_pkgs. For now this should be the last change before the swap. Hope you can take a look. Thanks!

@seanyen
Copy link
Contributor Author

seanyen commented Aug 8, 2019

The sporadic test failure happens again... but it seems not to do with this change.

__main__.TestRangePlugin.test_inside_range (from unittest.suite.TestSuite)

@chapulina chapulina merged commit ff1a2b5 into ros-simulation:melodic-devel Aug 8, 2019
@seanyen seanyen deleted the windows_build_fix branch August 8, 2019 23:46
nim65s referenced this pull request in nim65s/robotpkg Mar 9, 2020
patch-ab: adapt
patch-ad: python 3 compatibility

Changelog for package gazebo_ros
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2.8.6 (2019-12-26)
------------------
* ROS API: remove unhelpful error in GetWorldProperties call (`%747 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/747>`_)
* Create reconfigure thread only if network enabled (`%919 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/919>`_)
  This thread was blocked in client.waitForExistance because the services
  it depends on are only created if `enable_ros_network` is true. This in
  turn blocked gazebo from being shut down.
  Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* spawn_model: Fix urlparse imports for Python 3
* spawn_model: Ensure that "model_xml" is a string, required for Python 3
* catkin_find gazebo plugin from bin folder. (`%993 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/993>`_)
* [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_)
  * Fix CMake install error for Windows build.
  * conditionally include <sys/time.h>
* provide Windows implemenation for setenv. (`%879 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/879>`_)
* implement basic gazebo scripts to support launch file on Windows build. (`%880 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/880>`_)
* Contributors: Kartik Mohta, Kevin Allen, Sean Yen, Shane Loretz

2.8.5 (2019-06-04)
------------------
* Add output arg to launch files, plus some small fixes (melodic) (`%907 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/907>`_)
  * Add output arg to empty_world
  * add output arg to elevator_world
  * add output arg to range_world
  * don't set use_sim_time in range_world
  Instead parse it to empty world, where it will be set.
  * add xml prolog to all launch files
  * Remove unnecessary arg in range_world.launch
* use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_)
* fix issue `%198 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/198>`_ (`%825 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/825>`_)
* Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_)
* Contributors: Matthijs van der Burgh, Paul Bovbel, Sean Yen [MSFT], Steven Peters

Changelog for package gazebo_ros_control
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2.8.6 (2019-12-26)
------------------
* restrict Windows header namespace. (`%1023 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1023>`_)
* [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_)
  * Fix CMake install error for Windows build.
  * conditionally include <sys/time.h>
* Contributors: Sean Yen

2.8.5 (2019-06-04)
------------------
* use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_)
* Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_)
* Contributors: Paul Bovbel, Sean Yen [MSFT]

Changelog for package gazebo_plugins
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2.8.6 (2019-12-26)
------------------
* gazebo_plugins: export plugin path in package.xml (`%923 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/923>`_)
* Fix destructor of gazebo_ros_diff_drive.cpp (`%1021 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1021>`_)
  Fix issue referenced in `%123 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/123>`_ where the destructor of ROS DiffDrive plugin causes gzserver to crash on model deletion.
* [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_)
  * Fix CMake install error for Windows build.
  * conditionally include <sys/time.h>
* Use ignition::math::Rand utility for portability. (`%878 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/878>`_)
* Contributors: Ben Wolsieffer, RemiRigal, Sean Yen

2.8.5 (2019-06-04)
------------------
* use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_)
* Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_)
* Contributors: Paul Bovbel, Sean Yen [MSFT]
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
…#975)

* Fix CMake install error for Windows build.

* conditionally include <sys/time.h>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants