Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fix_build branch for indigo-devel (fix compilation for gazebo4) #222

Merged
merged 3 commits into from
Aug 14, 2014

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Aug 5, 2014

I've ported the pull request #221 and target it to indigo. It is not exactly the same, some changes are not needed in the indigo branch.

//cc @nkoenig @hsu @adolfo-rt

@scpeters
Copy link
Member

I fixed a few more deprecation warnings for gazebo 4 in c95a9c1

@hsu
Copy link
Collaborator

hsu commented Aug 13, 2014

Jose, did you take a look at the compatibility_gazebo_4.0 branch? and there's one for hydro too (compatibility_gazebo_4.0_hydro)

@scpeters
Copy link
Member

@hsu I think this branch is a little bit cleaner and fixes all the warnings. You removed PCL in that branch in one place, but that is being taken care of by #180 (which looks really good to me; I just don't know how to test it).

@hsu
Copy link
Collaborator

hsu commented Aug 13, 2014

+1
just went through the diff, this one is more complete. Thanks!

@scpeters
Copy link
Member

+1

hsu added a commit that referenced this pull request Aug 14, 2014
Port fix_build branch for indigo-devel (fix compilation for gazebo4)
@hsu hsu merged commit 2f3f0f3 into indigo-devel Aug 14, 2014
@adolfo-rt
Copy link

The gazebo_ros_control part looks fine.

@scpeters scpeters deleted the fix_build_indigo branch April 29, 2015 00:57
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
…ndigo

Port fix_build branch for indigo-devel (fix compilation for gazebo4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants