also support gazebo instead of gazebo_ros for package exports #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for plugin_path, gazebo_model_path or gazebo_media_path exports
|
Within the 3
What if we installed it in both? @hsu can you give your thoughts on these things? As a side note, we should switch the functions |
|
bump. Can you add those deprecated warnings, then we can merge this. Thanks! |
package name for exported paths
davetcoleman
added a commit
that referenced
this pull request
Jun 27, 2013
…ugins_patch also support gazebo instead of gazebo_ros for package exports
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the renaming of the
gazeboROS package ingazebo_roscompared to the simulator_gazebo stack numerous packages that want to export plugin paths, model paths or media paths have to be updated and depend on the new gazebo_ros package now. But in fact the gazebo_ros_paths_plugin is only a helper to add the paths using the gazebo API and the semantics is more like exporting these paths for gazebo. I would strongly recommend to additionally support "gazebo" as a package name when searching for packages that export gazebo paths.The same problem exists for the run scripts currently installed in lib/gazebo_ros/, forcing all users to update their launch files. Would it be very "bad" to install them in lib/gazebo/ instead or create symlinks there to not break existing launch files using
<node name="gazebo" pkg="gazebo" type="gazebo">...</node>?Having to maintain different branches for each ROS distro of repositories with packages using gazebo is quite annoying and should be avoided (although it's rarely possible due to other changes in the API). This is especially true if there are no (visible) fundamental changes but only small renamings.