Fix sensors after time reset #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
World resets result in a negative time differences between current world time and the last recorded sensor update time, preventing the plugin from publishing new frames. This commit detects such events and resets the internal sensor update timestamp.
|
@osrf-jenkins run tests please |
1 similar comment
|
@osrf-jenkins run tests please |
Roboterbastler
pushed a commit
to Roboterbastler/gazebo_ros_pkgs
that referenced
this pull request
Jul 6, 2018
* camera plugin keeps publishing after negative sensor update interval World resets result in a negative time differences between current world time and the last recorded sensor update time, preventing the plugin from publishing new frames. This commit detects such events and resets the internal sensor update timestamp. * block_laser, range, and joint_state_publisher keep publishing after clock reset * p3d keeps publishing after clock reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various gazebo sensor plugins not publishing ROS messages after resetting the Gazebo world (CTRL+R).
Tested on gazebo9. Currently includes:
These are the sensors on the prius vehicle in github.com/osrf/car_demo .
In all these plugins, resetting the time in Gazebo results in negative time difference between the current time and last update time, which prevents any new messages being send. The fix explicitly detects such negative time differences. With it, the simulation in osrf/car_demo can be reset without affecting ROS.
By the way, this seems related to #532, though kennysharm'a pull request, nor #540 fixes this.