Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename tf frame names via ros params #38

Open
wants to merge 2 commits into
base: lunar-devel
Choose a base branch
from

Conversation

pabloinigoblasco
Copy link

No description provided.

@wjwwood
Copy link
Member

wjwwood commented Sep 10, 2016

Thanks for the pr! We'll get to reviewing it as soon as possible.

@gerkey fyi.

@pabloinigoblasco
Copy link
Author

Anything you need, please don't hesitate to ask

@wjwwood wjwwood closed this May 1, 2017
@wjwwood wjwwood changed the base branch from master to lunar-devel May 1, 2017 03:23
@wjwwood
Copy link
Member

wjwwood commented May 1, 2017

Sorry, I accidentally closed this when changing the branch layout of the repository. I've reopened it and updated the target base to be lunar-devel which is the new default branch. You can edit again to point at indigo-devel, which is what is used to release for ROS Indigo and Kinetic, if you like.

@wjwwood wjwwood reopened this May 1, 2017
@davidbsp
Copy link

A suggestion: add camera_frame_id as well. Thanks.

@amattag
Copy link

amattag commented Mar 12, 2020

Has this problem been fixed in ros-melodic-stage?
I am having this problem with ros melodic. The /robot_0/base_laser_link frame name must be changed to robot_0/base_laser_link frame. Otherwise a simulation with multiple robots/objects will not work.
Had to switch back to ros-kinetic.

@davidbsp
Copy link

davidbsp commented Mar 12, 2020

Hi Antonio,
I don't think that the problem has been fixed, as the latest commits to this pkg are from May 2017.
However, you can use @doisyg 's version of the stage_ros pkg.
Just clone it from here and compile it in your catkin_ws. You also have an example launch file here as well.

@doisyg
Copy link

doisyg commented Mar 12, 2020

@amattag , see my corresponding PR (would love to see it merged btw) with example launch file: #58

@amattag
Copy link

amattag commented Mar 15, 2020

Thanks @doisyg for your work, it's really helpful. But, I am still having problems with an stage world with multiple robots.
For robot_0, stage names the laser frame as "/robot_0/base_laser_link". With your ros-stage PR I can rename the "base_laser_link" part of the laser frame id, but it attaches it to the "/robot_0" prefix.
I need to change the whole thing to "robot_0/base_laser_link".
Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants