Foxy updates #25
Merged
Foxy updates #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artivis <jeremie.deray@canonical.com>
Also: clean up some stale comments remove dependency on twist_mux_msgs which contains some empty action interfaces (WIP?) convert rearrange package.xml so it validates against schema (as verified with ament_xmllint)
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
|
I've retargeted to foxy-devel. |
|
I branched off #18 and added my thing, I did some super basic test and it works. (ie publishing on one topic and it being republished to other topic). |
|
I disabled the test that was failing (test needs migration still) but the code works fine, tested multiple topics with different priorities and joystick priority. |
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some arguments and updates for foxy on top of #18
We may want a foxy branch instead of merging to dashing.