Dashing devel #18
Closed
Dashing devel #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artivis <jeremie.deray@canonical.com>
Also: clean up some stale comments remove dependency on twist_mux_msgs which contains some empty action interfaces (WIP?) convert rearrange package.xml so it validates against schema (as verified with ament_xmllint)
bmagyar
requested changes
Apr 6, 2020
bmagyar
reviewed
Apr 6, 2020
bmagyar
reviewed
Apr 6, 2020
| # TODO(artivis) use rate once available | ||
| time.sleep(cls.MESSAGE_TIMEOUT) | ||
| # TODO wait_for_msg-like functionnality not yet available | ||
| # https://github.com/ros2/rclcpp/issues/520 |
There was a problem hiding this comment.
These in-code TODO-s will be forgotten and never addressed. Could you please instead open an issue on github with some detail and put TODO: link.... here?
bmagyar
reviewed
Apr 6, 2020
|
|
||
| # Wait for previously published messages to time out, | ||
| # since we aren't restarting twist_mux. | ||
| # | ||
| # This sleeping time must be higher than any of the | ||
| # timeouts in system_test_config.yaml. | ||
| rospy.sleep(self.MESSAGE_TIMEOUT + self.TOPIC_TIMEOUT) | ||
| # | ||
| # TODO(artivis) use rate once available |
There was a problem hiding this comment.
These in-code TODO-s will be forgotten and never addressed. Could you please instead open an issue on github with some detail and put TODO: link.... here?
bmagyar
reviewed
Apr 6, 2020
|
how about with ROS2 eloquent? |
|
@bmagyar Is this ready to be merged yet? Looks like it has been sitting a bit and the ros-planning/dashing-devel branch is still at ROS1 stuff. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported except joystick_relay node