Remove --pytest-with-coverage option from default colcon test command #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
requested review from
emersonknapp and
prajakta-gokhale
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 39.90% 38.96% -0.94%
==========================================
Files 2 2
Lines 213 213
Branches 39 39
==========================================
- Hits 85 83 -2
- Misses 128 130 +2
Continue to review full report at Codecov.
|
emersonknapp
approved these changes
Mar 17, 2021
christophebedard
deleted the
remove-pytest-with-coverage-option-colcon-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally added in #109 to avoid hardcoding the pytest coverage options. However, instead of using this option by default, users can simply use the
coverage-pytesttest mixin explicitly if they want to: https://github.com/colcon/colcon-mixin-repository/blob/1ddb69bedfd1f04c2f000e95452f7c24a4d6176b/coverage.mixin#L14Signed-off-by: Christophe Bedard bedard.christophe@gmail.com