-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove colcon-mixin-name #591
Remove colcon-mixin-name #591
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 38.63% 38.46% -0.18%
==========================================
Files 2 2
Lines 220 221 +1
Branches 41 42 +1
==========================================
Hits 85 85
- Misses 135 136 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This removes
colcon-mixin-name
and updates examples & tests to usecolcon-defaults
instead.I also fixed some issues that I uncovered:
asan
mixin doesn't exist;asan-gcc
doesoptions.env
, you probably want to includeprocess.env
, otherwise the environment gets reset to nothing + whatever you provide withoptions.env
; this was making runs that usedcolcon-defaults
with C++ packages fail because cmake couldn't find any compilercolcon
uses/root/
as the home directory for some reason (you can see this when the action runscolcon mixin update ...
), which isn't the same home directory that we use when deleting the.colcon/
directory to clean up between jobsSigned-off-by: Christophe Bedard bedard.christophe@gmail.com