Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colcon-mixin-name #591

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Remove colcon-mixin-name #591

merged 4 commits into from
Mar 23, 2021

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Mar 21, 2021

This removes colcon-mixin-name and updates examples & tests to use colcon-defaults instead.

I also fixed some issues that I uncovered:

  • asan mixin doesn't exist; asan-gcc does
  • when setting options.env, you probably want to include process.env, otherwise the environment gets reset to nothing + whatever you provide with options.env; this was making runs that used colcon-defaults with C++ packages fail because cmake couldn't find any compiler
  • for Docker jobs, colcon uses /root/ as the home directory for some reason (you can see this when the action runs colcon mixin update ...), which isn't the same home directory that we use when deleting the .colcon/ directory to clean up between jobs

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard requested a review from a team as a code owner March 21, 2021 15:57
@christophebedard christophebedard requested review from emersonknapp and jaisontj and removed request for a team March 21, 2021 15:57
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #591 (8d47b91) into master (3018c9a) will decrease coverage by 0.17%.
The diff coverage is 20.00%.

❗ Current head 8d47b91 differs from pull request most recent head 7ca7dcc. Consider uploading reports for the commit 7ca7dcc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   38.63%   38.46%   -0.18%     
==========================================
  Files           2        2              
  Lines         220      221       +1     
  Branches       41       42       +1     
==========================================
  Hits           85       85              
- Misses        135      136       +1     
Impacted Files Coverage Δ
src/action-ros-ci.ts 29.16% <20.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3018c9a...7ca7dcc. Read the comment docs.

@christophebedard
Copy link
Member Author

After merging this, we can probably close #526 and #525.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emersonknapp emersonknapp enabled auto-merge (squash) March 23, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants