Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all packages in workspace by default #682

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Test all packages in workspace by default #682

merged 2 commits into from
Jun 16, 2021

Conversation

emersonknapp
Copy link
Contributor

Fixes #61

@emersonknapp emersonknapp requested a review from a team as a code owner June 16, 2021 00:48
@emersonknapp emersonknapp requested review from christophebedard and Karsten1987 and removed request for a team June 16, 2021 00:48
@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #682 (7eac2f7) into master (6ffa14e) will increase coverage by 11.47%.
The diff coverage is 70.00%.

❗ Current head 7eac2f7 differs from pull request most recent head 0d51a00. Consider uploading reports for the commit 0d51a00 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #682       +/-   ##
===========================================
+ Coverage   38.52%   50.00%   +11.47%     
===========================================
  Files           2        2               
  Lines         231      240        +9     
  Branches       46       52        +6     
===========================================
+ Hits           89      120       +31     
+ Misses        142      120       -22
Impacted Files Coverage Δ
src/action-ros-ci.ts 43.12% <70.00%> (+13.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffa14e...0d51a00. Read the comment docs.

Test all packages in workspace by default
6e0e1a9 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
christophebedard
christophebedard reviewed Jun 16, 2021
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
Update package-name documentation, add linux test for all packages in…
0d51a00 
… repo, update step ids, test for both packages built

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
christophebedard
christophebedard approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emersonknapp emersonknapp merged commit 3882d9d into master Jun 16, 2021
@emersonknapp emersonknapp deleted the emersonknapp/build-all-pkgs branch June 16, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmichaels11 zmichaels11 zmichaels11 approved these changes

@christophebedard christophebedard christophebedard approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow build/test all packages by default
3 participants
@emersonknapp @christophebedard @zmichaels11