-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cURL in favor of using vcstool's ability to import URLs #683
Conversation
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 240 238 -2
Branches 52 52
=======================================
- Hits 120 119 -1
+ Misses 120 119 -1
Continue to review full report at Codecov.
|
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Seems like I think import * as url from "url";
// ...
return url.pathToFileURL(path.resolve(vcsRepoFileUrl)).href; |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
I added it: 39c7964 |
Thanks for fixing that! |
Replaces #328 (thanks @rotu for starting it)
vcstool
can take URLs, we can simplify logic by using this instead of expecting curl installed, or configuring it with advanced options